Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Zendesk Support: Replace ZendeskSupportAuditLogsIncrementalSync with low-code #53620

Merged
merged 13 commits into from
Feb 13, 2025
Merged

Source Zendesk Support: Replace ZendeskSupportAuditLogsIncrementalSync with low-code #53620

merged 13 commits into from
Feb 13, 2025

Conversation

pabloescoder
Copy link
Collaborator

@pabloescoder pabloescoder commented Feb 10, 2025 •
edited
Loading

What

Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/11511

How

By replacing ZendeskSupportAuditLogsIncrementalSync with low-code DatetimeBasedCursor and adding a request param to filter records by stream_interval start and end time.

Review guide

  1. manifest.yaml
  2. components.py

User Impact

No impact, enables concurrent CDK framework.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Acceptance Criteria

  • The audit_logs stream no longer defines the custom component ZendeskSupportAuditLogsIncrementalSync
  • The audit_logs stream supports incremental syncs
  • ZendeskSupportAuditLogsIncrementalSync is deleted from components.py
  • All tests in /unit_tests pass.
  • All CI checks are passing ✅
  • Live traffic regression test suite run with passing results
  • Progressive rollout starting with 20%, 50%, followed by release of the candidate version

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 3:45pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 10, 2025
@pabloescoder
Copy link
Collaborator Author

pabloescoder commented Feb 10, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (2e82b0e)

@brianjlai
Copy link
Contributor

brianjlai commented Feb 11, 2025 •
edited
Loading

@DanyloGL let's kickoff a regression test run of source-zendesk-support running. Given the scope of @pabloescoder 's changes, we really only care about the audit_logs stream so testing against just that should be sufficient. If these look good when tested incrementally (full refresh if you want additional validation), then we can begin a progressive rollout

ah sorry my mistake, I didn't realize we'd already kicked off a run. thanks @DanyloGL . If we see no mismatches on audit_logs then I think this is ready to go. you can use the /approve-regression-tests to run the CI that will approve the regression test step after you've checked the results match

@DanyloGL
Copy link
Collaborator

@brianjlai, regression looks not bad. Affected stream retrieves the same amount of records. On tested connection audit_logs stream has too small amount of data (14-15 records). Tested it on cloud with our sandbox that contains Live data (thousands of records on this stream) and it retrieved the same records as prod connector version.

@brianjlai
Copy link
Contributor

@DanyloGL excellent! Can you start a progressive rollout by modifying the image tags and merge this PR in?

and nice work @pabloescoder

@DanyloGL
Copy link
Collaborator

DanyloGL commented Feb 13, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (02d6fce)

DanyloGL
DanyloGL approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@DanyloGL DanyloGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting Progressive Rollout

@DanyloGL DanyloGL merged commit c553718 into master Feb 13, 2025
28 checks passed
@DanyloGL DanyloGL deleted the source-zendesk-support-replace-ZendeskSupportAuditLogsIncrementalSync branch February 13, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanyloGL DanyloGL DanyloGL approved these changes

@brianjlai brianjlai Awaiting requested review from brianjlai

@natikgadzhi natikgadzhi Awaiting requested review from natikgadzhi

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pabloescoder @brianjlai @DanyloGL @octavia-squidington-iii